executor: avoid goroutine leak in index Lookup join (#19251) #20791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
challenge-program
component/executor
difficulty/easy
sig/execution
update code
delete index lookup merge join
|
/merge |
|
Sorry @fzhedu, this branch cannot be merged without an approval of release maintainers |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19251 to release-3.0
What problem does this PR solve?
Issue Number: close #19354
Problem Summary: the index lookup join leak goroutines if inner works build innerExec failed, because it returns immediately after opened, ignore closing.
besides, if one innerworker find
ctx.Done(), it returns but lettask.innerResultis null, which is later called but without judgement. This causes panic.What is changed and how it works?
Proposal: xxx
What's Changed:
move
defer innerExec.closebefore return errors.judgen
task.innerResultbefore using it.How it Works:
Related changes
Check List
Tests
Side effects
Release note