-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: use kv.Key as reorg progress marker instead of kv.Handle #20908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What problem does this PR solve?
Issue Number: close #20727
Problem Summary:
What is changed and how it works?
What's Changed:
The reason why TiDB decodes keys to handles during 'ADD INDEX' is that the reorganization progress is persisted in storage. The handles are used as the progress marker. This PR change the type of marker to
kv.Key
.How it Works:
Using `kv.Key as the marker skips the decoding routine.
Related changes
N/A
Check List
Tests
Side effects
Release note