Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unexpected results when do index merge join on outer join (#20581) #20954

Merged
merged 4 commits into from
Nov 13, 2020
Merged

executor: fix unexpected results when do index merge join on outer join (#20581) #20954

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
259666e
cherry pick #20581 to release-4.0
lzmhhh123 Nov 10, 2020
e56f76a
Merge branch 'release-4.0' into release-4.0-658a4ce26a25
ti-srebot Nov 12, 2020
b329bc4
Merge branch 'release-4.0' into release-4.0-658a4ce26a25
ti-srebot Nov 13, 2020
2ffde00
Merge branch 'release-4.0' into release-4.0-658a4ce26a25
ti-srebot Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions executor/index_lookup_merge_join.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,9 @@ func (imw *innerMergeWorker) doMergeJoin(ctx context.Context, task *lookUpMergeJ
for _, outerIdx := range task.outerOrderIdx {
outerRow := task.outerResult.GetRow(outerIdx)
hasMatch, hasNull, cmpResult := false, false, initCmpResult
if task.outerMatch != nil && !task.outerMatch[outerIdx.ChkIdx][outerIdx.RowIdx] {
goto missMatch
}
// If it has iterated out all inner rows and the inner rows with same key is empty,
// that means the outer row needn't match any inner rows.
if noneInnerRowsRemain && len(task.sameKeyInnerRows) == 0 {
Expand Down