Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: generate proper hint for IndexHashJoin / IndexMergeJoin (#20992) #21020

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20992 to release-4.0


What problem does this PR solve?

Issue Number: close #20991

Problem Summary:

The join hint generated by explain format = 'hint' would not work if the join is index hash join or index merge join.

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Generate proper hint for IndexHashJoin / IndexMergeJoin`

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@SunRunAway
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2020
@qw4990 qw4990 merged commit 5ba8f67 into pingcap:release-4.0 Nov 30, 2020
@eurekaka eurekaka deleted the release-4.0-1804f4c53a28 branch November 30, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/sql-plan-management sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants