Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: fix insert value into hash partition table which not int (#21182) #21238

Merged
merged 3 commits into from
Nov 25, 2020
Merged

table: fix insert value into hash partition table which not int (#21182) #21238

merged 3 commits into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21182 to release-4.0

What problem does this PR solve?

Issue Number: close #21172

Problem Summary:

What is changed and how it works?

What's Changed:

change the locateHashPartition function, when the column is not int, it will first convert int.

How it Works:

change the locateHashPartition function, when the column is not int, it will first convert int.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
      No
    • Consumes more MEM
      No
  • Breaking backward compatibility
    No

Release note

  • fix insert value into hash partition table which not int

@newcworld @ti-srebot
cherry pick pingcap#21182 to release-4.0
b08d309 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 24, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 24, 2020
@ti-srebot ti-srebot self-assigned this Nov 24, 2020
@ti-srebot
Copy link
Contributor Author

@ti-srebot you're already a collaborator in bot's repo.

@lzmhhh123 lzmhhh123 assigned lzmhhh123 and unassigned ti-srebot Nov 24, 2020
@lzmhhh123
Copy link
Contributor

/run-all-tests

1 similar comment
@lzmhhh123
Copy link
Contributor

/run-all-tests

Reminiscent
Reminiscent reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
SunRunAway
SunRunAway approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21171
  • 21146

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 2b841dd into pingcap:release-4.0 Nov 25, 2020
@SunRunAway SunRunAway deleted the release-4.0-ca247e8928f8 branch November 25, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

@lzmhhh123 lzmhhh123

Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @lzmhhh123 @SunRunAway @Reminiscent @newcworld