Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix unit test for tidb_opt_prefer_range_scan variable #21294

Merged
merged 3 commits into from
Nov 25, 2020
Merged

planner: fix unit test for tidb_opt_prefer_range_scan variable #21294

merged 3 commits into from
Nov 25, 2020

Conversation

xiaodong-ji
Copy link
Contributor

@xiaodong-ji xiaodong-ji commented Nov 25, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Problem Summary:

close #21093, close #21092

What is changed and how it works?

What's Changed: add unit test for tidb_opt_prefer_range_scan variable.

Related changes

Check List

Tests

  • Unit test

Release note

  • fix unit test for tidb_opt_prefer_range_scan variable

@xiaodong-ji xiaodong-ji requested a review from a team as a code owner November 25, 2020 10:13
@xiaodong-ji xiaodong-ji requested review from hanfei1991 and removed request for a team November 25, 2020 10:13
winoros
winoros reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
SunRunAway
SunRunAway approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@SunRunAway SunRunAway added the type/bugfix This PR fixes a bug. label Nov 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiaodong-ji merge failed.

@winoros
Copy link
Member

winoros commented Nov 25, 2020

/run-unit-test

@winoros winoros merged commit 084e719 into pingcap:master Nov 25, 2020
@xiaodong-ji xiaodong-ji mentioned this pull request Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@SunRunAway SunRunAway SunRunAway approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
4 participants
@xiaodong-ji @SunRunAway @ti-srebot @winoros