statistics: fix a bug which causes panic when using the clustered index and the new collation (#21379) #21408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
component/statistics
type/4.0-cherry-pick
type/bugfix
|
@wjhuang2016 you're already a collaborator in bot's repo. |
|
Merge this PR after backporting pinyin collation to release 4.0. |
|
/run-all-tests |
|
/run-all-tests |
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
zhouqiang-cl
added
the
cherry-pick-approved
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21379 to release-4.0
What problem does this PR solve?
Issue Number: close #20876
Problem Summary:
The statistics data is "sort key" and shouldn't take as collate strings. If so, reencode the non-UTF-8 sort key may cause panic.
What is changed and how it works?
Don't set collate for the sort key.
Related changes
Check List
Tests
Side effects
Release note