planner: report error for invalid window specs which are not used (#21083) #21976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/planner
|
@dyzsr you're already a collaborator in bot's repo. |
|
/run-all-tests tidb-test=pr/1153 |
|
/run-common-test tidb-test=pr/1153 |
|
/run-integration-common-test tidb-test=pr/1153 |
zz-jason
previously approved these changes
Jan 25, 2021
ti-srebot
added
status/LGT2
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
|
/run-integration-common-test tidb-test=pr/1153 |
|
Should we merge https://github.com/pingcap/tidb-test/pull/1153 first? @dyzsr |
Yes |
|
/run-all-tests tidb-test=pr/1153 |
|
/run-all-tests |
|
/run-all-tests |
qw4990
approved these changes
Jan 27, 2021
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21083 to release-4.0
What problem does this PR solve?
Issue Number: close #12356
Problem Summary: Didn't check for invalid window specs if they are not used in window functions.
What is changed and how it works?
windowOrderBy,partitionBy.groupWindowFuncsto store unused named window specs.buildWindowFunctions.Related changes
Check List
Tests
Side effects
Release note