-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: improve the runtime stats of index lookup reader (#21982) #22136
executor: improve the runtime stats of index lookup reader (#21982) #22136
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@crazycs520 you're already a collaborator in bot's repo. |
executor/distsql.go
Outdated
@@ -622,10 +622,15 @@ func (e *IndexLookUpExecutor) initRuntimeStats() { | |||
if e.runtimeStats != nil { | |||
if e.stats == nil { | |||
e.stats = &IndexLookUpRunTimeStats{ | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL @crazycs520
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
cherry-pick #21982 to release-4.0
What problem does this PR solve?
close #21981
The
IndexRangeScan
runtime stats ofIndexLookUp
executor is not accurate.What is changed and how it works?
IndexLookUp
.index_task: indicate the time cost of the index-worker to fetch handles.
table-worker
.table_task: indicate the time cost of the table-worker to fetch rows.
IndexRangeScan
runtime stats.Example:
Related changes
Check List
Tests
Side effects
Release note