Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix select into outfile with year type column has no data (#22175) #22185

Merged
merged 2 commits into from
Jul 14, 2021
Merged

executor: fix select into outfile with year type column has no data (#22175) #22185

merged 2 commits into from
Jul 14, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 5, 2021 •
edited by xiongjiwei
Loading

cherry-pick #22175 to release-4.0

What problem does this PR solve?

Issue Number: close #22159

Problem Summary:

What is changed and how it works?

add year type column in dumpToOutfile

Check List

Tests

  • Unit test

Release note

  • fix a bug that select into outfile has no data with year column type

@xiongjiwei @ti-srebot
cherry pick pingcap#22175 to release-4.0
551a00d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@github-actions github-actions bot added the sig/execution SIG execution label Jan 5, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2021
@xiongjiwei xiongjiwei requested review from wjhuang2016, a team, XuHuaiyu and ichn-hu and removed request for a team and XuHuaiyu July 8, 2021 12:32
@zhouqiang-cl zhouqiang-cl added backport-4.0.14 cherry-pick-approved Cherry pick PR approved by release team. labels Jul 9, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 551a00d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2021
@zhouqiang-cl
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 48b204d into pingcap:release-4.0 Jul 14, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.14 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.14
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @sre-bot @ti-chi-bot @zhouqiang-cl @wjhuang2016 @lzmhhh123 @ichn-hu @xiongjiwei