-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcworker: fix gc miss locks when region merged during scanning & resolving locks (#22252) #22267
Merged
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-bedd599e06c6
Jan 7, 2021
Merged
gcworker: fix gc miss locks when region merged during scanning & resolving locks (#22252) #22267
ti-srebot
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-bedd599e06c6
Jan 7, 2021
+96
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
component/GC
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Jan 7, 2021
@lysu you're already a collaborator in bot's repo. |
Signed-off-by: lysu <sulifx@gmail.com>
youjiali1995
approved these changes
Jan 7, 2021
MyonKeminta
approved these changes
Jan 7, 2021
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jan 7, 2021
/merge |
Sorry @jebter, this branch cannot be merged without an approval of release maintainers. |
/label release-team-approved |
These labels are not found |
/approve |
ti-srebot
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Jan 7, 2021
/merge |
Sorry @zz-jason, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter,you06 for more details. |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jan 7, 2021
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/GC
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT3
The PR has already had 3 LGTM.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22252 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr 550916624
After apply modifications, you can push your change to this PR via:
Signed-off-by: lysu sulifx@gmail.com
What problem does this PR solve?
Issue Number: close #22245
Problem Summary:
just as
TestResolveLockRangeMeetRegionEnlargeCausedByRegionMerge
What is changed and how it works?
What's Changed, How it Works:
we need re-scan region's lock when found merged region's EndKey 's larger than origional region's EndKey
Related changes
Check List
Tests
Side effects
Release note
This change is