executor: store correct plan hint in statements_summary when log level is 'debug' (#22219) #22293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22219 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr 22293
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22203
Problem Summary:
Baseline capture does not work as expected.
What is changed and how it works?
What's Changed:
Make sure
planHint
is correctly set instatements_summary
when the log level isdebug
or thetidb_slow_log_threshold
is set to 0.How it Works:
getEncodedPlan
may be called inLogSlowQuery
which would only generate encoded plan(i.e, with no plan hint), we should make sure the consequentgetEncodedPlan
call inSummaryStmt
can generate plan hint then.Related changes
Check List
Tests
Side effects
N/A
Release note