Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, executor: fix runtime panic in WEIGHT_STRING function when the length of binary is too large (#22251) #22332

Merged
merged 4 commits into from
Jan 25, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 11, 2021

cherry-pick #22251 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr 22332

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22332:ti-srebot:release-4.0-b8c91d14ef9c

What problem does this PR solve?

Issue Number: close #22201

Problem Summary:

What is changed and how it works?

What's Changed:
fix runtime panic in WEIGHT_STRING function when the length of binary is too large
How it Works:
mysql

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix runtime panic in WEIGHT_STRING function when the length of binary/char is too large

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot you're already a collaborator in bot's repo.

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2021
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
@zz-jason zz-jason added the type/bugfix This PR fixes a bug. label Jan 25, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 25, 2021

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 25, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 25, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21323
  • 21329
  • 21404
  • 21443
  • 21473
  • 21477
  • 21582
  • 21593
  • 21602
  • 21604
  • 21610
  • 21623
  • 21635
  • 21958
  • 22116
  • 22148
  • 22353
  • 21488
  • 21546
  • 21573
  • 21608
  • 21665
  • 21673
  • 21718
  • 21785
  • 21810
  • 21813
  • 21971
  • 21916
  • 21969
  • 22022

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit e7ddaa5 into pingcap:release-4.0 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants