planner: check index valid while forUpdateRead (#22152) #22365
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22152 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr 22365
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
cherry pick #21596 to master as a temporary solution.
Issue Number: close #21498
Problem Summary:
ForUpdateRead will read data using schema version of startTS, this may lead to incorrectness, the cases are listed in #21498
What is changed and how it works?
What's Changed:
For RC and forUpdateRead in RR, check if index's state is still
StatePublic
.How it Works:
This check confirms index between snapshotTS and forUpdateTS is not changed, otherwise, the index should not be used.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note