Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix subQuery at projection in only_full_group #22416

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zhaoxugang
Copy link
Contributor

@zhaoxugang zhaoxugang commented Jan 16, 2021

PR Title Format:

  1. core: fix subQuery at projection in only_full_group

What problem does this PR solve?

Issue Number: close #17731

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

core:fix query with missing column in group by is executed

  • core: fix subQuery at projection in only_full_group

@zhaoxugang zhaoxugang requested a review from a team as a code owner January 16, 2021 14:27
@zhaoxugang zhaoxugang requested review from eurekaka and removed request for a team January 16, 2021 14:27
@ti-challenge-bot
Copy link

There is no reward for this challenge pull request, so you can request a reward from @lzmhhh123.

Details

Tip : About reward you can refs to reward-command.

Warning: None

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2021

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ichn-hu ichn-hu mentioned this pull request Jan 16, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2021

@zhaoxugang zhaoxugang changed the title fix only full group bug core: fix subQuery at projection in only_full_group Jan 16, 2021
@zhaoxugang
Copy link
Contributor Author

/rebuild

@zhaoxugang
Copy link
Contributor Author

PTAL @eurekaka

@XuHuaiyu XuHuaiyu added contribution This PR is from a community contributor. sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Feb 22, 2021
planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2021
@qw4990 qw4990 removed their request for review June 24, 2021 06:20
# Conflicts:
#	planner/core/integration_test.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2021
@zhaoxugang
Copy link
Contributor Author

/rebuild

@zhaoxugang zhaoxugang requested a review from eurekaka July 25, 2021 03:50
@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2022

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.6397%. Comparing base (a33d971) to head (9944d1e).
Report is 5944 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #22416         +/-   ##
=================================================
+ Coverage   61.8770%   73.6397%   +11.7627%     
=================================================
  Files           885        971         +86     
  Lines        282407     308635      +26228     
=================================================
+ Hits         174745     227278      +52533     
+ Misses        93934      66989      -26945     
- Partials      13728      14368        +640     

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full group by violation: query with missing column in group by is executed
6 participants