store/tikv: remove dependency on testkit #22520
Conversation
| @@ -11,7 +11,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package tikv_test | |||
There was a problem hiding this comment.
It is a little strange to put the coprocessor test file in the /store directly, however, I do not know where would be better
There was a problem hiding this comment.
agree. I think we can consider it later.
| ) | ||
|
|
||
| // NewTestStore creates a kv.Storage for testing purpose. | ||
| func NewTestStore(c *C) kv.Storage { |
There was a problem hiding this comment.
why not use tikv.NewTestStore directly?
There was a problem hiding this comment.
it's in _test.go file, we cannot import it.
There was a problem hiding this comment.
Could we move it to tikv/test_util.go so we can use it here?
There was a problem hiding this comment.
I'll give it a try.
There was a problem hiding this comment.
@AndreMouche Looks we cannot do it. The reason is that NewTestStore relies on the testing flags with-tikv and pd-addrs. If they are included in non-testing packages, the flags will appear in the flag list of tidb-server.
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
/run-all-tests |
What problem does this PR solve?
Remove
store/tikv's dependency onutil/testkit.Part of #22513
What is changed and how it works?
What's Changed:
Move test files out of the package.
Check List
Tests
Release note