Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: refactor: remove import tidb.config.security in store/tikv #22538

Merged
merged 7 commits into from
Jan 27, 2021
Merged

store/tikv: refactor: remove import tidb.config.security in store/tikv #22538

merged 7 commits into from
Jan 27, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: part of #22513

Problem Summary:
store/tikv has dependency on tidbconfig.Security

What is changed and how it works?

What's Changed:
Remove tidbconfig.Security from store/tikv and create a new struct Security for tikv

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/tikv:remove import config.security from tidb config
57c90ba 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
store/tikv:remove import config.security from tidb config
df5128b 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche requested a review from a team as a code owner January 26, 2021 09:56
@AndreMouche AndreMouche requested review from wshwsh12 and removed request for a team January 26, 2021 09:56
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Jan 26, 2021
andylokandy
andylokandy previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2021
disksing
disksing reviewed Jan 26, 2021
View reviewed changes
store/tikv/config/security.go
@@ -0,0 +1,71 @@
package config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some head ?

AndreMouche and others added 2 commits January 27, 2021 10:47
@AndreMouche
Merge branch 'master' into tikv/securiy
468f6dd
@AndreMouche
address comments
6db17d8 
Signed-off-by: shirly <AndreMouche@126.com>
AndreMouche and others added 3 commits January 27, 2021 11:27
@AndreMouche
address comments
d184aa6 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Merge branch 'master' into tikv/securiy
9ef1517
@AndreMouche
address comments
06d75cd 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 27, 2021
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit fbcf75a into pingcap:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@disksing disksing disksing approved these changes

@andylokandy andylokandy andylokandy left review comments

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@andylokandy andylokandy

@disksing disksing

Labels
component/config component/store sig/execution SIG execution sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreMouche @disksing @ti-srebot @andylokandy