Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: resolve metrics dependency #22542

Merged
merged 6 commits into from
Jan 28, 2021
Merged

store/tikv: resolve metrics dependency #22542

merged 6 commits into from
Jan 28, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jan 26, 2021 •
edited
Loading

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Resolve metrics related dependencies.
Part of #22513

What is changed and how it works?

What's Changed:

  • Move metrics variables to store/tikv/metrics
  • Add functions to allow reset namespace and subsystem
  • Update usage

Note: not all metrics are migrated.

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing
store/tikv: resolve metrics dependency
07feb87 
Signed-off-by: disksing <i@disksing.com>
AndreMouche
AndreMouche previously approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
andylokandy
andylokandy previously approved these changes Jan 28, 2021
View reviewed changes
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2021
ti-srebot
ti-srebot previously approved these changes Jan 28, 2021
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 28, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22566

@disksing disksing dismissed stale reviews from ti-srebot and andylokandy via f31174d January 28, 2021 10:16
@disksing
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@disksing
Copy link
Contributor Author

/merge

2 similar comments
@disksing
Copy link
Contributor Author

/merge

@disksing
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

1 similar comment
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e8395b7 into pingcap:master Jan 28, 2021
@disksing disksing deleted the metrics branch January 28, 2021 11:08
@disksing disksing mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@andylokandy andylokandy andylokandy left review comments

@ti-srebot ti-srebot ti-srebot left review comments

Assignees
No one assigned
Labels
component/store status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @ti-srebot @AndreMouche @andylokandy