Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv:remove tidb/config from store/tikv #22606

Merged
merged 8 commits into from
Feb 1, 2021
Merged

store/tikv:remove tidb/config from store/tikv #22606

merged 8 commits into from
Feb 1, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: part of #22513

Problem Summary:
store/tikv:remove import tidb/config from store/tikv

What is changed and how it works?

What's Changed:
store/tikv: remove import tidb/config from store/tikv

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/tikv:remove tidb/config from store/tikv
66c60f0 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
merge master & fix conflicts
8c4e861 
Signed-off-by: shirly <AndreMouche@126.com>
@bb7133
Copy link
Member

bb7133 commented Jan 28, 2021 •
edited
Loading

Please fix the CI 'checkfmt'.

@AndreMouche
gofmt
598574d 
Signed-off-by: shirly <AndreMouche@126.com>
disksing
disksing reviewed Jan 29, 2021
View reviewed changes
store/tikv/config/config.go Outdated Show resolved Hide resolved
store/tikv/config/config.go Outdated Show resolved Hide resolved
youjiali1995
youjiali1995 reviewed Jan 29, 2021
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
disksing
disksing previously approved these changes Feb 1, 2021
View reviewed changes
@ti-srebot
Copy link
Contributor

@disksing, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Feb 1, 2021
@andylokandy
Copy link
Contributor

/lgtm

ti-srebot
ti-srebot previously approved these changes Feb 1, 2021
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 1, 2021
@andylokandy
Copy link
Contributor

/rebuld

@andylokandy
Copy link
Contributor

/rebuild

@AndreMouche
merge master & fix conflits
d7f951d 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche dismissed stale reviews from ti-srebot and disksing via d7f951d February 1, 2021 09:29
@AndreMouche
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 1, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@AndreMouche
tikv/config:change to use pingcap/errors
0c958d8 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@andylokandy
Copy link
Contributor

/lgtm

@andylokandy
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@disksing
Copy link
Contributor

disksing commented Feb 1, 2021

/merge

@ti-srebot ti-srebot merged commit 85a9669 into pingcap:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 left review comments

@andylokandy andylokandy andylokandy approved these changes

@disksing disksing disksing approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

Assignees
No one assigned
Labels
component/config component/store sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreMouche @bb7133 @ti-srebot @andylokandy @disksing @youjiali1995