Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: cleanup warnings and unused code #22648

Merged
merged 5 commits into from
Feb 2, 2021
Merged

store/tikv: cleanup warnings and unused code #22648

merged 5 commits into from
Feb 2, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Feb 1, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

cleanup some warnings and unused code
Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2021
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 2, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@disksing merge failed.

@youjiali1995
Copy link
Contributor

/merge

2 similar comments
@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/merge

@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/merge

@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7fbe3e5 into pingcap:master Feb 2, 2021
@disksing disksing deleted the unused branch February 2, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/store sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants