store/tikv: move EtcdBackend out #22676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
github-actions
bot
added
sig/execution
Signed-off-by: disksing <i@disksing.com>
|
/run-all-tests |
|
/run-all-tests |
youjiali1995
approved these changes
Feb 3, 2021
|
@youjiali1995, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIGs: execution(slack),sql-infra(slack). |
youjiali1995
approved these changes
Feb 3, 2021
ti-srebot
approved these changes
Feb 3, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
AndreMouche
reviewed
Feb 3, 2021
| type EtcdBackend interface { | ||
| EtcdAddrs() ([]string, error) | ||
| TLSConfig() *tls.Config | ||
| StartGCWorker() error |
There was a problem hiding this comment.
Why StartGCWorker is part of EtcdBackend?
ichn-hu
added a commit
to ichn-hu/tidb
that referenced
this pull request
Mar 10, 2021
This reverts commit 7a275a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
EtcdBackendinterface is not used bystore/tikv, so move it out.Part of #22513
Check List
Tests
Release note