ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (2) #22729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afe API(2) Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
|
LGTM |
ti-srebot
approved these changes
Feb 5, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
/run-tics-test |
1 similar comment
|
/run-tics-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #22935 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0-rc in PR #22936 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #22937 |
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Mar 3, 2021
AilinKid
pushed a commit
that referenced
this pull request
Mar 4, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Issue Number: part close #pingcap/tidb-test#1152
What is changed and how it works?
What's Changed:
Migrate part of code in ddl package from using Execute/ExecRestricted to safe API
Attention:
1: Since partitionDef.Expr string may contain the identifier, we won't pass it as a parameter but write it to SQL string directly.
2: Since the condition string in partitionDef.less-than field contains the quotation ", so trimming need be done before it passed as a string parameter.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note