Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fixed error msg in builtinArithmeticMinusIntSig #22822

Closed
wants to merge 7 commits into from
Closed

expression: fixed error msg in builtinArithmeticMinusIntSig #22822

wants to merge 7 commits into from

Conversation

Tjianke
Copy link
Contributor

@Tjianke Tjianke commented Feb 19, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #22749

Problem Summary:

What is changed and how it works?

What's Changed:

Tests

  • Unit test
  • Integration test

Release note

  • fixed error msg

@sre-bot
Copy link
Contributor

sre-bot commented Feb 19, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@Tjianke Tjianke changed the title fixed error msg expression: fixed error msg Feb 19, 2021
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 19, 2021

/run-all-tests

@Tjianke Tjianke changed the title expression: fixed error msg expression: fixed error msg in builtinArithmeticMinusIntSig Feb 19, 2021
@Tjianke Tjianke marked this pull request as ready for review February 19, 2021 12:32
@Tjianke Tjianke requested a review from a team as a code owner February 19, 2021 12:32
@Tjianke Tjianke requested review from lzmhhh123 and removed request for a team February 19, 2021 12:32
@ichn-hu ichn-hu mentioned this pull request Feb 20, 2021
Closed
XuHuaiyu
XuHuaiyu reviewed Feb 22, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@XuHuaiyu
Copy link
Contributor

PTAL @lzmhhh123

lzmhhh123
lzmhhh123 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22846

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@Tjianke merge failed.

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 22, 2021

/run-all-tests

1 similar comment
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 22, 2021

/run-all-tests

@ti-chi-bot
Copy link
Member

Merge canceled because a new commit is pushed.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

@Tjianke: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 22, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2021
@Tjianke
Copy link
Contributor Author

Tjianke commented Feb 28, 2021

change already merged in #22426

@Tjianke Tjianke closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
component/expression size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading error format in minus function
7 participants
@Tjianke @sre-bot @XuHuaiyu @lzmhhh123 @ti-srebot @ti-chi-bot @CLAassistant