Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: let tikv know primary prefix columns info #22829

Merged
merged 7 commits into from
Mar 1, 2021
Merged

planner: let tikv know primary prefix columns info #22829

merged 7 commits into from
Mar 1, 2021

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Feb 19, 2021

Signed-off-by: lysu sulifx@gmail.com

What problem does this PR solve?

Issue Number: ref #22811

need fix in tikv

Problem Summary:

tikv now didn't read value even if key only contain prefix of column value when primary key's column is cb(1)

What is changed and how it works?

What's Changed, How it Works:

set field for pingcap/tipb#214

to put prefixed info down to tikv to let it read value even due to key only contains prefix

and handle it in tikv tikv/tikv#9670

Related changes

  • n/a

Check List

Tests

  • Integration test

Side effects

  • n/a

Release note

  • n/a

This change is Reviewable

@lysu lysu requested review from a team as code owners February 19, 2021 12:40
@lysu lysu requested review from wshwsh12 and lzmhhh123 and removed request for a team February 19, 2021 12:40
@lysu lysu added the type/bugfix This PR fixes a bug. label Feb 19, 2021
@lysu
Copy link
Contributor Author

lysu commented Feb 19, 2021

need merge pingcap/tipb#214 first

@lysu lysu changed the title planner: give tikv about primary prefix columns info. planner: give tikv about primary prefix columns info Feb 19, 2021
@lysu lysu changed the title planner: give tikv about primary prefix columns info planner: let tikv know primary prefix columns info. Feb 19, 2021
@lysu lysu changed the title planner: let tikv know primary prefix columns info. planner: let tikv know primary prefix columns info Feb 19, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Feb 19, 2021
@lysu
Copy link
Contributor Author

lysu commented Feb 20, 2021

/run-check_dev_2 tikv=pr/9670

@coocood
Copy link
Member

coocood commented Feb 20, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2021
table/tables/tables.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7971ce2e037b4abe4c49b980d1124911058a129

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2021
@ti-chi-bot
Copy link
Member

@lysu: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor Author

lysu commented Feb 24, 2021

need merge tikv/tikv#9670 first to make default run-all-tests can pass

@lysu
Copy link
Contributor Author

lysu commented Feb 25, 2021

/run-sqllogic-test1 tidb-test=pr/1164
/run-sqllogic-test2 tidb-test=pr/1164

2 similar comments
@lysu
Copy link
Contributor Author

lysu commented Feb 25, 2021

/run-sqllogic-test1 tidb-test=pr/1164
/run-sqllogic-test2 tidb-test=pr/1164

@lysu
Copy link
Contributor Author

lysu commented Feb 25, 2021

/run-sqllogic-test1 tidb-test=pr/1164
/run-sqllogic-test2 tidb-test=pr/1164

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

@ti-chi-bot update this PR

Signed-off-by: lysu <sulifx@gmail.com>
Signed-off-by: lysu <sulifx@gmail.com>
Signed-off-by: lysu <sulifx@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2021
ti-chi-bot pushed a commit to tikv/tikv that referenced this pull request Mar 1, 2021
Signed-off-by: lysu <sulifx@gmail.com>

<!--
Thank you for contributing to TiKV!

If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two.

PR Title Format:
1. module [, module2, module3]: what's changed
2. *: what's changed

If you want to open the **Challenge Program** pull request, please use the following template:
https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md
You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md
-->

### What problem does this PR solve?

Issue Number: close pingcap/tidb#22811

Problem Summary:

tikv will avoid read value when required column in common handle

but common handle's columns maybe not contain full columns value (like `primary key(c(1))`)

### What is changed and how it works?

What's Changed:

read kv's value when required column in common handle is the prefix of column

need merge pingcap/tidb#22829 first

### Related changes

- n/a

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

- Integration test(WIP)

Side effects

- n/a

### Release note <!-- bugfixes or new feature need a release note -->

- no release note

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tikv/tikv/9670)
<!-- Reviewable:end -->
@lysu
Copy link
Contributor Author

lysu commented Mar 1, 2021

/run-check_dev_2 tikv=pr/9670

@lysu lysu requested a review from tangenta March 1, 2021 04:57
@coocood
Copy link
Member

coocood commented Mar 1, 2021

LGTM

@ti-chi-bot
Copy link
Member

@coocood: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor Author

lysu commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@lysu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff6f930

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@ti-chi-bot
Copy link
Member

@lysu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6bd6df7 into pingcap:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants