Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (1) (#22670) #22929

Merged
merged 7 commits into from
Mar 10, 2021
Merged

ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (1) (#22670) #22929

merged 7 commits into from
Mar 10, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 25, 2021 •
edited
Loading

cherry-pick #22670 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22929

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22929:release-4.0-75f7485688ba

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: part close #pingcap/tidb-test#1152

What is changed and how it works?

What's Changed:

Migrate part of code in ddl package from using Execute/ExecRestricted to safe API

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (1).

@AilinKid @ti-srebot
cherry pick pingcap#22670 to release-4.0
3473330 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Feb 25, 2021
Merged
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2021
@ti-srebot ti-srebot added this to the v4.0.11 milestone Feb 25, 2021
@ti-srebot
Copy link
Contributor Author

@AilinKid you're already a collaborator in bot's repo.

@AilinKid
address comment
a15c38d 
Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2021
@AilinKid
.
5020897 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
Copy link
Contributor

AilinKid commented Mar 9, 2021

/run-all-tests

@AilinKid
Copy link
Contributor

AilinKid commented Mar 9, 2021

/run-check_dev

@AilinKid
Copy link
Contributor

AilinKid commented Mar 9, 2021

/run-unit-test

1 similar comment
@xhebox
Copy link
Contributor

xhebox commented Mar 10, 2021

/run-unit-test

@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
.
101d3a0 
Signed-off-by: ailinkid <314806019@qq.com>
@xhebox
Copy link
Contributor

xhebox commented Mar 10, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
@AilinKid
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2021
@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5633595

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2021
@AilinKid
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 51158bd into pingcap:release-4.0 Mar 10, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.11, v4.0.12 Mar 26, 2021
@qw4990 qw4990 mentioned this pull request Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@morgo morgo Awaiting requested review from morgo

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@xhebox xhebox Awaiting requested review from xhebox

Assignees

@AilinKid AilinKid

Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.12
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @AilinKid @xhebox @ti-chi-bot @xiongjiwei @zhouqiang-cl