Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix wrong table filters for index merge plan (#23132) #23166

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 8, 2021

cherry-pick #23132 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23166

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23166:release-5.0-rc-9ac5b7ae3669

What problem does this PR solve?

Issue Number: close #23112

Problem Summary:

Wrong result for index merge plan.

What is changed and how it works?

What's Changed:

Keep the whole DNF filter if any partial path contains table filters.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix wrong table filters for index merge plan

@ti-srebot ti-srebot requested a review from a team as a code owner March 8, 2021 07:52
@ti-srebot ti-srebot requested review from eurekaka and removed request for a team March 8, 2021 07:52
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-rc-cherry-pick type/bugfix This PR fixes a bug. labels Mar 8, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2021
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka eurekaka force-pushed the release-5.0-rc-9ac5b7ae3669 branch from 9f99f51 to 2e1a7d0 Compare March 8, 2021 09:12
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 8, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@eurekaka eurekaka force-pushed the release-5.0-rc-9ac5b7ae3669 branch from 2e1a7d0 to 31bee13 Compare March 8, 2021 09:17
@eurekaka
Copy link
Contributor

eurekaka commented Mar 8, 2021

/run-all-tests

Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 8, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2021
@eurekaka eurekaka merged commit 31c2570 into pingcap:release-5.0-rc Mar 8, 2021
@eurekaka eurekaka deleted the release-5.0-rc-9ac5b7ae3669 branch March 8, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants