Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: add test for analyze single partition #23167

Merged
merged 8 commits into from
Mar 8, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Mar 8, 2021

What problem does this PR solve?

Problem Summary:

Add a test to verify the two behaviors:

  1. When analyzing a single partition, we will try to build global stats. If another partition doesn't have stats, be failed and return warnings.
  2. After analyzing a single partition, we should have stats in mysql.stats_fm_sketch

Check List

Tests

  • Unit test

Side effects

Release note

  • No release note

@rebelice rebelice requested a review from a team as a code owner March 8, 2021 07:56
@rebelice rebelice requested review from XuHuaiyu and removed request for a team March 8, 2021 07:56
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Mar 8, 2021

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Mar 8, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Mar 8, 2021

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 March 8, 2021 07:56
@rebelice
Copy link
Contributor Author

rebelice commented Mar 8, 2021

/cc @Reminiscent

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failed test. Rest LGTM

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2021
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 8, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: acb16de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2021
@ti-chi-bot
Copy link
Member

@rebelice: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Mar 8, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit b42a6f4 into pingcap:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants