planner/core: pass the elems info to fieldtype only for exchanger #23203
Conversation
ti-chi-bot
added
the
size/M
|
/LGTM |
planner/core/plan_to_pb.go
Outdated
| for _, e := range column.RetType.Elems { | ||
| pbType.Elems = append(pbType.Elems, e) | ||
| } |
There was a problem hiding this comment.
| for _, e := range column.RetType.Elems { | |
| pbType.Elems = append(pbType.Elems, e) | |
| } | |
| pbType.Elems = append(pbType.Elems, column.RetType.Elems...) |
| for _, elem := range pbType.Elems { | ||
| tp.Elems = append(tp.Elems, elem) | ||
| } |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 659c9b6
|
ti-chi-bot
added
the
status/can-merge
|
@hanfei1991: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
TiFlash must know the elems info of enum type when decoding the enum data. Especially in MPP mode, we can't get the table schema after shuffle, then we must pass the elems to the tipb plans.
What is changed and how it works?
Related changes
pingcap/tipb: add elems for fieldtype tipb#217Check List
Tests
Release note