Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix clustered keyword regexp #23264

Merged

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 11, 2021

What problem does this PR solve?

Problem Summary:

According to MySQL documentation,

The key attribute PRIMARY KEY can also be specified as just KEY when given in a column definition.

We should also match the pattern for statements like

create table t1 (id int, a varchar(255) key clustered);

What is changed and how it works?

This is a patch for #23247.

Related changes

NA

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • No release note

@tangenta tangenta requested a review from a team as a code owner March 11, 2021 09:34
@tangenta tangenta requested review from lzmhhh123 and removed request for a team March 11, 2021 09:34
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2021
@lysu
Copy link
Contributor

lysu commented Mar 11, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@lysu lysu requested a review from coocood March 11, 2021 13:15
@coocood
Copy link
Member

coocood commented Mar 11, 2021

/lgtm

@coocood
Copy link
Member

coocood commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e9560b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot
Copy link
Member

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7ea78e7 into pingcap:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants