Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "executor: open childExec during execution for UnionExec (#21561) #23276

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Revert "executor: open childExec during execution for UnionExec (#21561) #23276

merged 3 commits into from
Mar 12, 2021

Conversation

XuHuaiyu
Copy link
Contributor

This reverts commit 0eb8ff9.

What problem does this PR solve?

Problem Summary:
The modification is not tested fully, so we decide to revert it temporarily.

Related changes

N/A

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • The OOM risk of reading the partition table will increase.

Release note

  • No release note

@XuHuaiyu XuHuaiyu added the sig/execution SIG execution label Mar 12, 2021
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner March 12, 2021 03:42
@XuHuaiyu XuHuaiyu requested review from qw4990 and removed request for a team March 12, 2021 03:42
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2021
@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@wshwsh12
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@XuHuaiyu
Copy link
Contributor Author

/run-tics-test

@XuHuaiyu
Copy link
Contributor Author

/run-check_dev

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@XuHuaiyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: af5934d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@XuHuaiyu
Copy link
Contributor Author

/run-check_dev

@ti-chi-bot
Copy link
Member

@XuHuaiyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu XuHuaiyu added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2021
@XuHuaiyu
Copy link
Contributor Author

/run-check-dev

@XuHuaiyu
Copy link
Contributor Author

/run-check_dev_2

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

1 similar comment
@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

/run-check_dev_2
/run-tics-test

@XuHuaiyu XuHuaiyu merged commit 30da0a1 into pingcap:master Mar 12, 2021
@XuHuaiyu XuHuaiyu deleted the revert_21561 branch March 12, 2021 06:59
@XuHuaiyu XuHuaiyu mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @wshwsh12 @ti-chi-bot @lzmhhh123