-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: optimize the performance of restore with db (#22910) #23283
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@rebelice you're already a collaborator in bot's repo. |
It's a release-blocker, could you update this PR? @rebelice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
I can not merge this PR now, because v4.0.12 is frozen. |
cherry-pick #22910 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23283
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22398
Problem Summary:
We use restore to generate SQL with default DB, it will consume more CPU. This problem will be more prominent in
batch insert
, becauseinsert
is usually faster. Also, the column list and the value list can be very long.In order to deal with this situation, for a simple
insert
, we do not use restore but string replacement.Related changes
Check List
Tests
Side effects
Release note