executor: refineArgs() bug fix when compare int with very small decimal (#23694)

[ti-srebot]

cherry-pick #23694 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23705

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23705:release-4.0-3ed4a23b956d

---

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number:
close #23623
close #23684

Problem Summary: In the following case, output of select stmt should be 2, but current result is 3.

Why: c1 is nullable, so we cannot assuse all value in c1 will be greater than the result of subquery, which is less than int32_min. Because result of null > xxx is NULL

drop table if exists t1;
create table t1(c1 int);
insert into t1 values(-2147483648), (-2147483648), (null);
select count(*) from t1 where c1 > (select sum(c1) from t1);

What is changed and how it works?

What's Changed: when refineArgs(), should check if column is nullable. If is nullable, we should not try to optimize compare expression.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Integration test

Side effects

• Performance regression
  • Consumes more CPU: may cause performance regression compared when compare int_column with const if int_column is nullable.

Release note

• fix bug when compare int_column with constant value

[ti-srebot]

/run-all-tests

[ti-srebot]

@lzmhhh123 you're already a collaborator in bot's repo.

[wshwsh12]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• ichn-hu
• wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[XuHuaiyu]

/merge

[lzmhhh123]

/merge

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[lzmhhh123]

/merge

[lzmhhh123]

/merge cancel

[lzmhhh123]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d1274ef