Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: append common handle columns into the schema of index merge table plan #23933

Merged
merged 9 commits into from
Apr 14, 2021
Merged

planner: append common handle columns into the schema of index merge table plan #23933

merged 9 commits into from
Apr 14, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Apr 9, 2021

What problem does this PR solve?

Issue Number: close #23906

Problem Summary:

Planner fails to build a plan.

What is changed and how it works?

What's Changed:

  • append common handle columns into the schema of index merge table plan

Related changes

N/A

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Append common handle columns into the schema of index merge table plan

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Apr 9, 2021
@eurekaka eurekaka requested a review from a team as a code owner April 9, 2021 09:36
@eurekaka eurekaka requested review from hanfei1991 and removed request for a team April 9, 2021 09:36
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2021
@eurekaka eurekaka removed the request for review from hanfei1991 April 9, 2021 09:37
@eurekaka
Copy link
Contributor Author

eurekaka commented Apr 9, 2021

/run-all-tests

@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@ichn-hu ichn-hu mentioned this pull request Apr 9, 2021
Closed
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2021
@winoros
Copy link
Member

winoros commented Apr 12, 2021

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 12, 2021

/merge

@eurekaka
Copy link
Contributor Author

/run-integration-compatibility-test
/run-unit-test

@eurekaka
Copy link
Contributor Author

/merge

tangenta
tangenta reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the following case still failed:

drop table if exists t;
create table t (a int, b int, c int, primary key (a, b) clustered, key idx_c(c));
insert into t values (0, 1, 2);
select /*+ use_index_merge(t) */ c from t where c > 10 or a < 1;
ERROR 1105 (HY000): invalid encoded key

@tangenta
Copy link
Contributor

/merge cancel

@ti-chi-bot
Copy link
Member

@tangenta: /merge cancel is only allowed for the PR author and the committers in list.

In response to this:

/merge cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@eurekaka eurekaka added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2021
@eurekaka
Copy link
Contributor Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta tangenta removed sig/execution SIG execution sig/planner SIG: Planner labels Apr 13, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e23abd5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@tangenta tangenta added the sig/planner SIG: Planner label Apr 13, 2021
@eurekaka
Copy link
Contributor Author

/run-all-tests

@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 50ea46c into pingcap:master Apr 14, 2021
@eurekaka eurekaka deleted the index_merge_common_handle branch April 14, 2021 12:58
@tangenta tangenta mentioned this pull request Apr 14, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24042

eurekaka added a commit to ti-srebot/tidb that referenced this pull request Apr 15, 2021
@eurekaka
cherry pick pingcap#23933 to release-5.0
90f5ec0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
planner: append common handle columns into the schema of index merge …
adec7d6 
…table plan (#23933) (#24042)
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find column when uses the clustered index
8 participants
@eurekaka @wjhuang2016 @ti-chi-bot @winoros @qw4990 @tangenta @ichn-hu @ti-srebot