-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: quickly process the next job after processing the cancelled DDL job #24146
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
I believe the behavior is correct. /lgtm |
PTAL @AilinKid |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 31b0193
|
/run-all-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #24254 |
What problem does this PR solve?
When the owner and the receiving DDL TiDB are on the same TiDB, quickly process the next job after processing the canceled DDL job.
What is changed and how it works?
When the DDL job is "JobStateRollbackDone", we notify the receiving DDL TiDB to process the finished job.
Add a log after the DDL JOB fails.
What's Changed:
How it Works:
This optimization also enables faster testing.
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
This optimization also enables faster testing.
Before this PR:
Executing
go test
takes 196.455s in the DDL package.After this PR:
Executing
go test
takes 134.877s in the DDL package.Release note