Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: invalidate stale regions for Mpp query. (#24410) #24432

Merged
merged 5 commits into from
Jun 18, 2021
Merged

store/copr: invalidate stale regions for Mpp query. (#24410) #24432

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c078991
cherry pick #24410 to release-5.0
hanfei1991 May 6, 2021
e8271f4
resolve
hanfei1991 May 13, 2021
aa1bf3b
Merge branch 'release-5.0' into release-5.0-c269b117054a
hanfei1991 Jun 15, 2021
149e5a8
address comments
hanfei1991 Jun 18, 2021
e243eb6
Merge branch 'release-5.0' into release-5.0-c269b117054a
hanfei1991 Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions store/copr/mpp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ func (m *mppIterator) handleDispatchReq(ctx context.Context, bo *tikv.Backoffer,
m.sendError(errors.New(realResp.Error.Msg))
return
}
for _, retry := range realResp.RetryRegions {
id := tikv.NewRegionVerID(retry.Id, retry.RegionEpoch.ConfVer, retry.RegionEpoch.Version)
logutil.BgLogger().Info("invalid region because tiflash detected stale region", zap.String("region id", id.String()))
m.store.GetRegionCache().InvalidateCachedRegionWithReason(id, tikv.EpochNotMatch)
}
failpoint.Inject("mppNonRootTaskError", func(val failpoint.Value) {
if val.(bool) && !req.IsRoot {
time.Sleep(1 * time.Second)
Expand Down
5 changes: 5 additions & 0 deletions store/tikv/region_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,11 @@ type RegionVerID struct {
ver uint64
}

// NewRegionVerID creates a region ver id, which used for invalidating regions.
func NewRegionVerID(id, confVer, ver uint64) RegionVerID {
return RegionVerID{id, confVer, ver}
}

// GetID returns the id of the region
func (r *RegionVerID) GetID() uint64 {
return r.id
Expand Down