-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger: fix the case which could have duplicate ranges (#24590) #24634
ranger: fix the case which could have duplicate ranges (#24590) #24634
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@winoros you're already a collaborator in bot's repo. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6a52bc9
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24590 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24634
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #24356
Problem Summary:
There're duplicate ranges for multi-column index when the last column is not prefix column but the columns before it is prefix column.
What is changed and how it works?
What's Changed:
Whether reset the
exclude status
of the interval point is decided by the last column's range.But whether to merge the ranges should be decided once the cut happens since we could not merge the ranges for the prefix column on the IN function. See the added tests.
Related changes
Check List
Tests
Release note