executor,table: fix 'show create table' for the temporary table #24857
Conversation
ti-chi-bot
added
the
size/M
|
PTAL @djshow832 @wjhuang2016 |
ddl/ddl_api.go
Outdated
| @@ -2225,7 +2225,7 @@ func handleTableOptions(options []*ast.TableOption, tbInfo *model.TableInfo) err | |||
| // We don't handle charset and collate here since they're handled in `getCharsetAndCollateInTableOption`. | |||
| case ast.TableOptionEngine: | |||
| if tbInfo.TempTableType != model.TempTableNone { | |||
| if op.StrValue != "" && !strings.EqualFold(op.StrValue, "memory") { | |||
| if op.StrValue != "" && !strings.EqualFold(op.StrValue, "memory") && !strings.EqualFold(op.StrValue, "innodb") { | |||
There was a problem hiding this comment.
We don't support innodb.
|
/lgtm |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b3b96e2
|
ti-chi-bot
added
the
status/can-merge
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
What problem does this PR solve?
Issue Number: close #24788 #24752
Problem Summary:
What is changed and how it works?
What's Changed:
Support
show create tablestatement for the temporary table.How it Works:
GLOBAL TEMPORARY ... ON COMMIT DELETE ROWSto the resultshow create tablestatement.Check List
Tests
Release note