Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: move tikv.keyranges and tikv.regioninfo to package store/… #24908

Merged
merged 9 commits into from
May 28, 2021
Merged

store/copr: move tikv.keyranges and tikv.regioninfo to package store/… #24908

merged 9 commits into from
May 28, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

store/copr: move tikv.keyranges and tikv.regioninfo to package store/copr since they are only used in coprocessor

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/copr: move tikv.keyranges and tikv.regioninfo to package store/…
2708657 
…copr since they are only used in coprocessor

Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 26, 2021
@AndreMouche
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 26, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2021
@AndreMouche
store/copr: use kv.KeyRange instead of tikv.KeyRange in KeyRanges
fba5b3c 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
tiny refactor
8e3c9f3 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label May 27, 2021
disksing
disksing reviewed May 27, 2021
View reviewed changes
store/tikv/region_cache.go Outdated Show resolved Hide resolved
store/copr/region_cache.go Show resolved Hide resolved
@AndreMouche
address comments
09f995b 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 28, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 28, 2021
@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 09f995b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2021
@ti-chi-bot
Copy link
Member

@AndreMouche: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7a15d64 into pingcap:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreMouche @ti-chi-bot @sticnarf @disksing