Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add foreign key compatibility for temporary table #24961

Merged
merged 12 commits into from
Jun 2, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented May 28, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: add foreign key compatibility for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: lihaowei <haoweili35@gmail.com>
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 28, 2021
@morgo
Copy link
Contributor

morgo commented May 28, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 28, 2021
@djshow832 djshow832 mentioned this pull request May 31, 2021
89 tasks
ddl/ddl_api.go Outdated Show resolved Hide resolved
Signed-off-by: lihaowei <haoweili35@gmail.com>
ddl/ddl_api.go Outdated Show resolved Hide resolved
Signed-off-by: lihaowei <haoweili35@gmail.com>
@Howie59 Howie59 requested a review from a team as a code owner June 2, 2021 05:22
@Howie59 Howie59 requested review from time-and-fate and removed request for a team June 2, 2021 05:22
Signed-off-by: lihaowei <haoweili35@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2021
Signed-off-by: lihaowei <haoweili35@gmail.com>
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@djshow832: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 392511f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2021
@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit da8dbe6 into pingcap:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants