-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: make pub vars related to region to private and add functions to set & get #25044
Conversation
Signed-off-by: shirly <AndreMouche@126.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b90f670
|
/run-all-tests |
@AndreMouche: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev_2 |
/run-all-tests |
/run-all-tests |
Signed-off-by: AndreMouche
What problem does this PR solve?
This PR makes some public vars which is related to the region to private, and add public functions to set and get. By this PR, we could move and rename the vars freely in the
go-client
package and do not need to update the tools which are using these vars, for example br and tidb.Part of #22513
Check List
Tests
Release note