store/tikv: move region_* into package store/tikv/region #25205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMouche
added
the
do-not-merge/work-in-progress
ti-chi-bot
added
size/XXL
AndreMouche
force-pushed
the
tikv/region
branch
2 times, most recently
from
bd54680
to
fbd3f10
Compare
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
This was referenced Jun 8, 2021
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
AndreMouche
requested review from
disksing,
sticnarf,
youjiali1995 and
andylokandy
|
/run-all-tests |
andylokandy
reviewed
Jun 8, 2021
store/tikv/region.go
Outdated
Comment on lines
13
to
58
| // RPCContext contains data that is needed to send RPC to a region. | ||
| type RPCContext = region.RPCContext | ||
|
|
||
| // RPCCanceller is rpc send cancelFunc collector. | ||
| type RPCCanceller = region.RPCCanceller | ||
|
|
||
| // RegionVerID is a unique ID that can identify a Region at a specific version. | ||
| type RegionVerID = region.VerID | ||
|
|
||
| // RegionCache caches Regions loaded from PD. | ||
| type RegionCache = region.Cache | ||
|
|
||
| // KeyLocation is the region and range that a key is located. | ||
| type KeyLocation = region.KeyLocation | ||
|
|
||
| // RPCCancellerCtxKey is context key attach rpc send cancelFunc collector to ctx. | ||
| type RPCCancellerCtxKey = region.RPCCancellerCtxKey | ||
|
|
||
| // RegionRequestSender sends KV/Cop requests to tikv server. It handles network | ||
| // errors and some region errors internally. | ||
| // | ||
| // Typically, a KV/Cop request is bind to a region, all keys that are involved | ||
| // in the request should be located in the region. | ||
| // The sending process begins with looking for the address of leader store's | ||
| // address of the target region from cache, and the request is then sent to the | ||
| // destination tikv server over TCP connection. | ||
| // If region is updated, can be caused by leader transfer, region split, region | ||
| // merge, or region balance, tikv server may not able to process request and | ||
| // send back a RegionError. | ||
| // RegionRequestSender takes care of errors that does not relevant to region | ||
| // range, such as 'I/O timeout', 'NotLeader', and 'ServerIsBusy'. For other | ||
| // errors, since region range have changed, the request may need to split, so we | ||
| // simply return the error to caller. | ||
| type RegionRequestSender = region.RequestSender | ||
|
|
||
| // StoreSelectorOption configures storeSelectorOp. | ||
| type StoreSelectorOption = region.StoreSelectorOption | ||
|
|
||
| // RegionRequestRuntimeStats records the runtime stats of send region requests. | ||
| type RegionRequestRuntimeStats = region.RequestRuntimeStats | ||
|
|
||
| // RPCRuntimeStats indicates the RPC request count and consume time. | ||
| type RPCRuntimeStats = region.RPCRuntimeStats | ||
|
|
||
| // CodecPDClient wraps a PD Client to decode the encoded keys in region meta. | ||
| type CodecPDClient = region.CodecPDClient |
There was a problem hiding this comment.
What's the reason for reexporting these types?
There was a problem hiding this comment.
Since we do not want the client to care about the sub-packages
Signed-off-by: shirly <AndreMouche@126.com>
ti-chi-bot
added
size/XL
disksing
reviewed
Jun 9, 2021
Signed-off-by: shirly <AndreMouche@126.com>
ti-chi-bot
added
size/XXL
disksing
approved these changes
Jun 9, 2021
Signed-off-by: shirly <AndreMouche@126.com>
sticnarf
approved these changes
Jun 10, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: eb04de0
|
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
|
/run-integration-common-test |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AndreMouche
What problem does this PR solve?
This PR moves tikv/region_*.go into package
store/tikv/regionPart of #22513
Check List
Tests
Release note