Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check filter condition in func convertToPartialTableScan #25294

Merged
merged 7 commits into from
Jun 16, 2021
Merged

planner: check filter condition in func convertToPartialTableScan #25294

merged 7 commits into from
Jun 16, 2021

Conversation

zhuo-zhi
Copy link
Contributor

@zhuo-zhi zhuo-zhi commented Jun 9, 2021

What problem does this PR solve?

Issue Number: close #25045

Problem Summary:

Cannot find column while use index merge

What is changed and how it works?

What's Changed:

  • Change logic in func convertToPartialTableScan.

How it Works:

  • Remove ineffective filter conditions in func convertToPartialTableScan to prevent use column out of the schema of PhysicalTableScan.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • planner: check filter condition in func convertToPartialTableScan

@zhuo-zhi zhuo-zhi requested review from a team as code owners June 9, 2021 07:11
@zhuo-zhi zhuo-zhi requested review from qw4990 and removed request for a team June 9, 2021 07:11
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 9, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 9, 2021
Closed
@qw4990 qw4990 requested a review from rebelice June 15, 2021 02:57
@ti-chi-bot
Copy link
Member

@rebelice: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@zhuo-zhi
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@zhuo-zhi: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f079563

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 16, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit efc774a into pingcap:master Jun 16, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 21, 2021
@zhuo-zhi @ti-srebot
cherry pick pingcap#25294 to release-5.1
1f314c2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 21, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25593

ti-chi-bot pushed a commit that referenced this pull request Jun 21, 2021
@ti-srebot
planner: check filter condition in func convertToPartialTableScan (#2…
cb42353 
…5294) (#25593)
@zhuo-zhi
Copy link
Contributor Author

/type needs-cherry-pick-5.0

@ti-chi-bot
Copy link
Member

@zhuo-zhi: The label(s) type/needs-cherry-pick-5.0 cannot be applied, because the repository doesn't have them.

In response to this:

/type needs-cherry-pick-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 28, 2021
@zhuo-zhi @ti-srebot
cherry pick pingcap#25294 to release-5.0
8f78c96 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25806

ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
planner: check filter condition in func convertToPartialTableScan (#2…
6f345df 
…5294) (#25806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice rebelice approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't find column while use index merge
6 participants
@zhuo-zhi @ti-chi-bot @qw4990 @ti-srebot @rebelice @lysu