Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Add err label for TiFlashQueryTotalCounter #25317

Merged
merged 11 commits into from
Jun 10, 2021
Merged

metrics: Add err label for TiFlashQueryTotalCounter #25317

merged 11 commits into from
Jun 10, 2021

Conversation

jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Jun 10, 2021 •
edited
Loading

What problem does this PR solve?

Pre Pull Request: #23426

What is changed and how it works?

What's Changed:
Add error label for TiFlashQueryTotalCounter
How it Works:
Add error label for TiFlashQueryTotalCounter, so that we can observe the error type in prometheus, and ignore some error we don't want to observe.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more MEM

Release note

  • metrics: Add err label for TiFlashQueryTotalCounter

@jyz0309
use err to instead err==nil
d7aab94 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
merge master
0e0c871 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
add error label for TiFlashQueryTotalCounter
93dc1d1 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309 jyz0309 requested a review from a team as a code owner June 10, 2021 02:19
@jyz0309 jyz0309 requested review from wshwsh12 and removed request for a team June 10, 2021 02:19
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2021
@jyz0309
remove useless import
f05d855 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
fix typo
5187272 
Signed-off-by: jyz0309 <45495947@qq.com>
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jun 10, 2021
@jyz0309 jyz0309 requested a review from crazycs520 June 10, 2021 02:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@jyz0309
use empty type
1baef80 
Signed-off-by: jyz0309 <45495947@qq.com>
@jyz0309
var
d50ad6d 
Signed-off-by: jyz0309 <45495947@qq.com>
crazycs520
crazycs520 reviewed Jun 10, 2021
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Jun 10, 2021
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Jun 10, 2021
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
@jyz0309
fix comment
7405df6 
Signed-off-by: jyz0309 <45495947@qq.com>
crazycs520
crazycs520 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2021
@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7405df6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2021
@crazycs520
Copy link
Contributor

/merge

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d37062f into pingcap:master Jun 10, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 10, 2021
@jyz0309 @ti-srebot
cherry pick pingcap#25317 to release-4.0
9a2003a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 10, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #25326

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 10, 2021
@jyz0309 @ti-srebot
cherry pick pingcap#25317 to release-5.0
0d25fbd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 10, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25327

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 10, 2021
@jyz0309 @ti-srebot
cherry pick pingcap#25317 to release-5.1
c1ed3d0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 10, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25328

ti-chi-bot pushed a commit that referenced this pull request Jun 11, 2021
@ti-srebot
metrics: Add err label for TiFlashQueryTotalCounter (#25317) (#25328)
da126da
ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
metrics: Add err label for TiFlashQueryTotalCounter (#25317) (#25327)
8af3a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@xhebox xhebox xhebox approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jyz0309 @ti-chi-bot @crazycs520 @zhouqiang-cl @ti-srebot @xhebox