-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: open childExec during execution for UnionExec (#24899) #25334
executor: open childExec during execution for UnionExec (#24899) #25334
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@XuHuaiyu you're already a collaborator in bot's repo. |
/cc @ichn-hu |
/cc @wshwsh12 |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 59b8939
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
1 similar comment
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24899 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25334
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #21441
re-revert #21561
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Before this commit,
Union
opens all the child executors during theOpen
phase.This increases the overhead of
buildRequest
and the risk of OOM.After this commit, the
Open
of childExec inUnion
is moved to theNext
phase. The childExec be opened simultaneously is limited totidb_executor_concurrency
atmost.How it Works:
Related changes
N/A
Check List
Tests
Suppose we have a table
t
, it contains 100 partitions, each partition contains 10,000,000 tuples.The result of
select * from t;
Before:
After:
The query works fine.
Side effects
tidb_executor_concurrency
.Release note
UnionExec
to reduce the overhead ofUnionExec
.