Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: open childExec during execution for UnionExec (#24899) #25334

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 10, 2021

cherry-pick #24899 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25334

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25334:release-5.1-56b6797ab1fc

What problem does this PR solve?

Issue Number: close #21441

re-revert #21561

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Before this commit, Union opens all the child executors during the Open phase.
This increases the overhead of buildRequest and the risk of OOM.

After this commit, the Open of childExec in Union is moved to the Next phase. The childExec be opened simultaneously is limited to tidb_executor_concurrency atmost.

How it Works:

Related changes

N/A

Check List

Tests

  • Integration test
  • Manual test
    Suppose we have a table t, it contains 100 partitions, each partition contains 10,000,000 tuples.
    The result of select * from t;
    Before:
    image
    After:
    The query works fine.

Side effects

  • The speed of UnionExec may decrease if the child of Union is larger than tidb_executor_concurrency.

Release note

  • Refine the execution mechanism UnionExec to reduce the overhead of UnionExec.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner June 10, 2021 08:03
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team June 10, 2021 08:03
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/executor sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.1-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jun 10, 2021
@ti-srebot
Copy link
Contributor Author

@XuHuaiyu you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

/cc @ichn-hu

@guo-shaoge
Copy link
Collaborator

/cc @wshwsh12

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 10, 2021
@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 59b8939

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 25dc28e into pingcap:release-5.1 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/executor sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants