Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix isTableAliasDuplicate, use schema.name as key when table has a alias name #25390

Closed
wants to merge 1 commit into from

Conversation

longfeiss
Copy link

What problem does this PR solve?

Issue Number: close #25364

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • No release note

@longfeiss longfeiss requested a review from a team as a code owner June 14, 2021 07:09
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@longfeiss longfeiss requested review from time-and-fate and removed request for a team June 14, 2021 07:09
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


longfei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2021
@ti-chi-bot
Copy link
Member

Welcome @longf2021!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@xiongjiwei
Copy link
Contributor

xiongjiwei commented Jun 15, 2021

hi @longf2021, can you please also take a look at #24622. Many thanks to you.

@ichn-hu ichn-hu mentioned this pull request Jun 15, 2021
@longfeiss
Copy link
Author

/rebuild

@xuyifangreeneyes
Copy link
Contributor

@oops-lgtm Hi, could you please add test for the pr, thx~

@longfeiss
Copy link
Author

close causing it's a wrong solution

@longfeiss longfeiss closed this Nov 29, 2021
@longfeiss longfeiss deleted the ti25364 branch November 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

same table alias is allowed in MySQL when tables come from different database
5 participants