Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner,executor: fix point get for update read panic on partition table #25537

Merged
merged 11 commits into from
Jun 18, 2021
Merged

planner,executor: fix point get for update read panic on partition table #25537

merged 11 commits into from
Jun 18, 2021

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #25528

Problem Summary:

#21148 add an extra partition ID column for the select lock executor, the table reader can handle it, but I forget the point / batch point get executor.

What is changed and how it works?

What's Changed:

Do not convert to point get executor for that case.
I see #21148 is already cherry picked to 5.1 and it introduce this bug, so it's better to fix the bug quickly.
This fix is simplest.

How it Works:

Avoid generate point get executor for that case.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

Fix a bug which is caused by prior bug fix PR

  • No release note

@tiancaiamao tiancaiamao requested review from a team as code owners June 17, 2021 14:59
@tiancaiamao tiancaiamao requested review from qw4990 and removed request for a team June 17, 2021 14:59
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 17, 2021
Closed
@github-actions github-actions bot added the sig/execution SIG execution label Jun 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 17, 2021
@lysu
Copy link
Contributor

lysu commented Jun 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 09d576a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/merge

@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01342a9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit 5645ede into pingcap:master Jun 18, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2021
@tiancaiamao @ti-srebot
cherry pick pingcap#25537 to release-5.1
422e516 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25552

@tiancaiamao tiancaiamao deleted the issue-25528 branch June 18, 2021 05:30
ti-chi-bot pushed a commit that referenced this pull request Jun 18, 2021
@ti-srebot
planner,executor: fix point get for update read panic on partition ta…
47aea09 
…ble (#25537) (#25552)
Yisaer pushed a commit to Yisaer/tidb that referenced this pull request Jun 18, 2021
@tiancaiamao @Yisaer
planner,executor: fix point get for update read panic on partition ta…
81493a7 
…ble (pingcap#25537)
@tiancaiamao tiancaiamao mentioned this pull request Jun 22, 2021
Merged
@qw4990
Copy link
Contributor

qw4990 commented Jul 15, 2021

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 15, 2021
@tiancaiamao @ti-srebot
cherry pick pingcap#25537 to release-4.0
fb3a449 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26274

ti-chi-bot pushed a commit that referenced this pull request Jul 16, 2021
@ti-srebot
planner,executor: fix point get for update read panic on partition ta…
558a62c 
…ble (#25537) (#26274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executor: point get for update read panic on partition table
5 participants
@tiancaiamao @ti-chi-bot @lysu @qw4990 @ti-srebot