Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix duplicate warnings for string-to-float truncation #25879

Closed
wants to merge 1 commit into from

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 1, 2021

What problem does this PR solve?

Issue Number: close #25829

select 1 in (0, '1a', 2); results in two warnings instead of one

What is changed and how it works?

getValidIntPrefix now calls getValidFloatPrefix with an extra parameter which disabled the call to HandleTruncate

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Fix duplicate warnings for truncation of DOUBLE

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 2, 2021
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that checks the number of warnings .

@ichn-hu
Copy link
Contributor

ichn-hu commented Jul 13, 2021

also please fix the CI

@dveeden dveeden marked this pull request as draft July 13, 2021 15:56
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2021
@ti-chi-bot
Copy link
Member

@dveeden: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2021
@dveeden dveeden closed this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count of warning information is double when use in function
3 participants