Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: rename stable-result-mode to ordered-result-mode #26093

Merged
merged 22 commits into from
Jul 12, 2021
Merged

planner: rename stable-result-mode to ordered-result-mode #26093

merged 22 commits into from
Jul 12, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 9, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: planner: rename stable-result-mode to ordered-result-mode

What is changed and how it works?

planner: rename stable-result-mode to ordered-result-mode

Check List

Tests

  • Unit test

Release note

  • No release note

@qw4990 qw4990 added the sig/planner SIG: Planner label Jul 9, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 9, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2021
@Reminiscent
Copy link
Contributor

Please fix the test in FAIL: set_test.go:41: testSerialSuite1.TestSetVar

zhangjinpeng87
zhangjinpeng87 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zhangjinpeng1987: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhangjinpeng87
Copy link
Contributor

Also should cherry pick to the latest release-4.0 branch

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

Also should cherry pick to the latest release-4.0 branch

Yes, I'll pick it after merging #25995, #26084

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

/run-all-tests

@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 12, 2021
@winoros
Copy link
Member

winoros commented Jul 12, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0d7c987

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 0db5df5 into pingcap:master Jul 12, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 12, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26093 to release-4.0
b0b2e46 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 12, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26133

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 12, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26093 to release-5.0
1750dc0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 12, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26134

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 12, 2021
@qw4990 @ti-srebot
cherry pick pingcap#26093 to release-5.1
19f0573 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 12, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26135

@qw4990 qw4990 mentioned this pull request Jul 13, 2021
Merged
zhouqiang-cl pushed a commit that referenced this pull request Jul 13, 2021
@qw4990
planner: rename stable-result-mode to ordered-result-mode (#26093) (#…
fb93942 
…26165)

* fixup
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2021
@ti-srebot
planner: rename stable-result-mode to ordered-result-mode (#26093) (#…
9e9f95c 
…26133)
ti-chi-bot pushed a commit that referenced this pull request Jul 20, 2021
@ti-srebot
planner: rename stable-result-mode to ordered-result-mode (#26093) (#…
7277e6b 
…26135)
ti-chi-bot pushed a commit that referenced this pull request Jul 27, 2021
@ti-srebot
planner: rename stable-result-mode to ordered-result-mode (#26093) (#…
95f9a39 
…26134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @Reminiscent @ti-chi-bot @zhangjinpeng87 @winoros @ti-srebot