executor: forbid read from stale query result (#25954)

[ti-srebot]

cherry-pick #25954 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26200

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26200:release-5.1-e04181b35193

---

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Refer #25876

Problem Summary: Because the design of planner, select SQL in the view is not preprocess/checked while creating. I mean all the handleTableName are ignored due to inCreateOrDropTable mask.

Stale reads, however, relies on handleTableName to get the needed information. And I did not come up with a solution to only preprocess/check-staleness for the table name in the select part but view name.

The result is that, I can not tell if it is a stale query while executing DDL create view, nor can we tell while executing/optimizing. Not from the preprocess result of the whole SQL. It can be extracted from the as ... part, though.

The check is added in the creation process(DDL) to reduce performance impact. It is added in executor, however, due to cyclic imports between planner and ddl.

Check List

Tests

• Unit test
• Integration test

Release note

• Forbid creating view from stale query

[ti-srebot]

/run-all-tests

[ti-srebot]

@xhebox you're already a collaborator in bot's repo.

[ti-chi-bot]

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[AilinKid]

LGTM

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• AilinKid
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[zhouqiang-cl]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d87f4a9

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.