Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update client-go to the new version #26256

Merged
merged 4 commits into from
Jul 15, 2021
Merged

go.mod: update client-go to the new version #26256

merged 4 commits into from
Jul 15, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR update client-go to the new version

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
go.mod: update client-go to the new version
dc39908 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2021
@AndreMouche
go.mod: update br to the new version
b7a050c 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
go.mod: fix bug in updating client-go
9269a51 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
iosmanthus
iosmanthus approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • iosmanthus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021
@AndreMouche
merge master & fix conflicts
bee358b 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bee358b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@AndreMouche
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 5ec3b34 into pingcap:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iosmanthus iosmanthus iosmanthus approved these changes

@disksing disksing disksing approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreMouche @ti-chi-bot @disksing @iosmanthus